Skip to content

Fix: use ViewKeyCache in volumetric fog instead of manually creating MeshPipelineViewLayoutKey#24090

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:24084_fix_atmosphere_volumetric_fog
May 3, 2026
Merged

Fix: use ViewKeyCache in volumetric fog instead of manually creating MeshPipelineViewLayoutKey#24090
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:24084_fix_atmosphere_volumetric_fog

Conversation

@kfc35
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 commented May 3, 2026

Objective

Solution

  • As @beicause mentioned, volumetric frog was calculating MeshPipelineViewLayoutKey manually when it could just rely on the ViewKeyCache instead, which has centralized logic for calculating it in check_views_need_specialization (STBN is added in impl From<MeshPipelineKey> for MeshPipelineViewLayoutKey)

Testing

  • cargo run --example atmosphere works now, no strobing!
  • cargo run --example volumetric_fog also works
  • cargo run --example scrolling_fog works

@kfc35 kfc35 added this to the 0.19 milestone May 3, 2026
@kfc35 kfc35 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering May 3, 2026
@kfc35 kfc35 requested a review from beicause May 3, 2026 03:34
@JMS55 JMS55 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 3, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 3, 2026
Merged via the queue into bevyengine:main with commit 20dc176 May 3, 2026
49 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants